[PATCH] D12887: [Machine Combiner] Refactor machine reassociation into a target-independent pass

Sanjay Patel via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 15 13:28:15 PDT 2015


spatel added a reviewer: Gerolf.
spatel added a comment.

I support refactoring the reassociation code to be target-independent, but I'm wondering: what is the benefit from making this a separate pass from MachineCombiner?

If I'm seeing it correctly, this patch has exactly duplicated a few hundred lines of code for MachineReassociation::reassociateInstructions() and its helpers from the existing pass.


Repository:
  rL LLVM

http://reviews.llvm.org/D12887





More information about the llvm-commits mailing list