[PATCH] D12874: [LLD/ELF2] Initial support for local symbols in symtab

[Davide Italiano via llvm-commits]

On Mon, Sep 14, 2015 at 10:54 PM, Sean Silva via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
> silvas added a subscriber: silvas.
>
> ================
> Comment at: test/elf2/local.s:14
> @@ +13,3 @@
> +// CHECK:     Address: 0x0
> +// CHECK:     Offset: 0x1000
> +// CHECK:     Size: 120
> ----------------
> Offset doesn't seem to matter for this test?
>
> ================
> Comment at: test/elf2/local.s:16-17
> @@ +15,4 @@
> +// CHECK:     Size: 120
> +// CHECK:     Link: 5
> +// CHECK:     Info: 4
> +// CHECK:     AddressAlignment: 8
> ----------------
> Do we care about these indices? We aren't checking that 5 and 4 are a particular thing.
>

Yes, I think we do, at least for sh_info. It should be equals to the
index of the last of the local symbols.
It makes sense to check we set that properly.

> ================
> Comment at: test/elf2/local.s:32
> @@ +31,3 @@
> +// CHECK:   Symbol {
> +// CHECK:     Name: blah (27)
> +// CHECK:     Value: 0x0
> ----------------
> I don't think we need to check the exact string table index.
>

Agree, as previously noted (in the first message), it needs a little
bit of cleanup.