[PATCH] D12874: [LLD/ELF2] Initial support for local symbols in symtab

Sean Silva via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 14 22:54:09 PDT 2015


silvas added a subscriber: silvas.

================
Comment at: test/elf2/local.s:14
@@ +13,3 @@
+// CHECK:     Address: 0x0
+// CHECK:     Offset: 0x1000
+// CHECK:     Size: 120
----------------
Offset doesn't seem to matter for this test?

================
Comment at: test/elf2/local.s:16-17
@@ +15,4 @@
+// CHECK:     Size: 120
+// CHECK:     Link: 5
+// CHECK:     Info: 4
+// CHECK:     AddressAlignment: 8
----------------
Do we care about these indices? We aren't checking that 5 and 4 are a particular thing.

================
Comment at: test/elf2/local.s:32
@@ +31,3 @@
+// CHECK:   Symbol {
+// CHECK:     Name: blah (27)
+// CHECK:     Value: 0x0
----------------
I don't think we need to check the exact string table index.


Repository:
  rL LLVM

http://reviews.llvm.org/D12874





More information about the llvm-commits mailing list