[PATCH] D12843: [Polly] Merge IRAccess into MemoryAccess

[Johannes Doerfert via llvm-commits]

> Meinersbur added a comment.
> 
> In http://reviews.llvm.org/D12843#245239, @llvm-commits wrote:
> 
> > > but their order might be different now.
> >
> >
> > I always believed the order of (non-scalar) memory accesses in the SCoP
> >  statement corresponded to the order of memory instructions in the basic
> >  block. Was this true would not be anymore? If so I would like to keep the
> >  old order if possible. If it wasn't true before, this comment is void.
> 
> 
> I think the order is undefined. Former TempScopInfo added IRAccesses to AccFuncMap (apart from the Functions set in buildAccessFunctions) depending on the order of iteration through the BBs, which is I think also undefined (but deterministic). Also its name is AccFuncSetType, indicating that it was never intended to make order matter. If this is wring, it should be documented.
Iterating over a BB has a defined order! I think we should not abandon
this for no good reason. At the latest the invariant hoisting patch will
make use of this (important for multiple ptr indirections).
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 213 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150914/5dd095ff/attachment.sig>