[PATCH] D12843: [Polly] Merge IRAccess into MemoryAccess

[Michael Kruse via llvm-commits]

Meinersbur added a comment.

In http://reviews.llvm.org/D12843#245239, @llvm-commits wrote:

> > but their order might be different now.
>
>
> I always believed the order of (non-scalar) memory accesses in the SCoP
>  statement corresponded to the order of memory instructions in the basic
>  block. Was this true would not be anymore? If so I would like to keep the
>  old order if possible. If it wasn't true before, this comment is void.


I think the order is undefined. Former TempScopInfo added IRAccesses to AccFuncMap (apart from the Functions set in buildAccessFunctions) depending on the order of iteration through the BBs, which is I think also undefined (but deterministic). Also its name is AccFuncSetType, indicating that it was never intended to make order matter. If this is wring, it should be documented.


================
Comment at: include/polly/ScopInfo.h:1479
@@ +1478,3 @@
+  /// @param Inst        The instruction doing the access. It is not necessarily
+  ///                    inside @p BB.
+  /// @param Type        The kind of access.
----------------
I was wondering why this is not always the case. Would save one parameter.


http://reviews.llvm.org/D12843