[PATCH] D12681: Calling conventions for HHVM

[Maksim Panchenko via llvm-commits]

maksfb added a comment.

Cool. Thanks.


================
Comment at: lib/Target/X86/X86ISelLowering.cpp:3874
@@ +3873,3 @@
+
+  if (IsTailCallConvention(CallingConv))
+    return IsVarArg ? false : TailCallOpt;
----------------
mcrosier wrote:
> While this looks correct, I'm not sure I agree with the refactoring.
Which part of it? The logic here is to check for a tail call calling convention, and I thought it'd better to maintain a single list of those.


http://reviews.llvm.org/D12681