[PATCH] D12681: Calling conventions for HHVM

[Chad Rosier via llvm-commits]

mcrosier added a comment.

Looks to be in pretty good shape, but I'm not confident enough in my review to give the final LGTM.  One minor nit.


================
Comment at: lib/Target/X86/X86ISelLowering.cpp:3874
@@ +3873,3 @@
+
+  if (IsTailCallConvention(CallingConv))
+    return IsVarArg ? false : TailCallOpt;
----------------
While this looks correct, I'm not sure I agree with the refactoring.


http://reviews.llvm.org/D12681