[PATCH] D12546: [WinEH] Emit prologues and epilogues for funclets

[Reid Kleckner via llvm-commits]

rnk added a comment.

Thanks!


================
Comment at: lib/CodeGen/AsmPrinter/WinException.cpp:477-479
@@ +476,5 @@
+          if (FuncInfo.CatchHandlerParentFrameObjOffset.empty()) {
+            // With the new IR, this is always 16 + 8 + getMaxCallFrameSize().
+            // Keep this in sync with X86FrameLowering::emitPrologue.
+            int ParentFrameOffset = MF->getFrameInfo()->getMaxCallFrameSize();
+            OS.EmitIntValue(ParentFrameOffset, 4); // ParentFrameOffset
----------------
majnemer wrote:
> This math seems off, what happened to `16 + 8`?
That's a real bug. The test case didn't catch it due to the missing colon. :(


http://reviews.llvm.org/D12546