[PATCH] D12546: [WinEH] Emit prologues and epilogues for funclets

[David Majnemer via llvm-commits]

majnemer added a comment.

LGTM with nits addressed.


================
Comment at: lib/CodeGen/AsmPrinter/WinException.cpp:477-479
@@ +476,5 @@
+          if (FuncInfo.CatchHandlerParentFrameObjOffset.empty()) {
+            // With the new IR, this is always 16 + 8 + getMaxCallFrameSize().
+            // Keep this in sync with X86FrameLowering::emitPrologue.
+            int ParentFrameOffset = MF->getFrameInfo()->getMaxCallFrameSize();
+            OS.EmitIntValue(ParentFrameOffset, 4); // ParentFrameOffset
----------------
This math seems off, what happened to `16 + 8`?

================
Comment at: lib/Target/X86/X86FrameLowering.cpp:1432-1433
@@ -1371,3 +1431,4 @@
                                           const TargetRegisterInfo *TRI) const {
   if (CSI.empty())
-    return false;
+    return true;
+
----------------
Please make this a separate change to ease bisecting.


http://reviews.llvm.org/D12546