[PATCH] D12692: LLVM does not distinguish Cortex-M4 from Cortex-M4F neither Cortex-R5 from R5F

[Renato Golin via llvm-commits]

rengolin added a reviewer: t.p.northover.
rengolin added a comment.

Adding Tim as a reviewer, as he was working on M-class Darwin. I'm not sure this change is welcome, or even valid, there.

I'm not particularly bothered by having the F variants per se, but this may create a conflict when using the GNU linker (which we do), so I wouldn't want to have to fix that, given that it was already refused once by Matt.

Alexandros, any special reason why you're adding this?

cheers,
--renato


================
Comment at: test/CodeGen/ARM/darwin-eabi.ll:4
@@ -3,3 +3,3 @@
 ; RUN: llc -mtriple=thumbv7-apple-darwin -mcpu=cortex-m3 < %s | FileCheck %s --check-prefix=CHECK-M3
-; RUN: llc -mtriple=thumbv7-apple-darwin -mcpu=cortex-m4 < %s | FileCheck %s --check-prefix=CHECK-M4
+; RUN: llc -mtriple=thumbv7-apple-darwin -mcpu=cortex-m4f < %s | FileCheck %s --check-prefix=CHECK-M4F
 
----------------
Not to mention that this is changing Darwin CPU names, which are normally a lot more strict than the rest...


http://reviews.llvm.org/D12692