[PATCH] D12318: [ASan] Enable optional ASan recovery

Kostya Serebryany via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 4 13:35:14 PDT 2015


kcc added a comment.

In http://reviews.llvm.org/D12318#240258, @ygribov wrote:

> > One more interesting question that came to my mind: is this going to be async-signal-safe?
>
> >  If not, the whole idea is kind of questionable.
>
>
> I don't see why it shouldn't - the only problematic place is acquiring the mutex which will either wait (in case reporting_tid is different from current_tid) or fail with informative message after timeout.
>
> > If you think it will, please add tests.
>
>
> I could generate errors in endless loop in a thread and bombard it with signals but that's probably not very reliable.


The more interesting would be to test the case where we have asan-ish reports in signal handlers (and at the same time in regular code).


Repository:
  rL LLVM

http://reviews.llvm.org/D12318





More information about the llvm-commits mailing list