[PATCH] D12596: Fix for bootstrap bug introduced in r244921

[Bill Schmidt via llvm-commits]

wschmidt added a comment.

First, congrats on sorting this out; bootstrap issues are always a pain.  I have one minor inline comment.  Also, can you add a test case for this situation?


================
Comment at: lib/Target/PowerPC/PPCISelDAGToDAG.cpp:2793
@@ -2786,1 +2792,3 @@
+          isa<LoadSDNode>(Op1.getOperand(0)) &&
+          NotDirectMovable) {
         LoadSDNode *LD = cast<LoadSDNode>(Op1.getOperand(0));
----------------
Minor nit: Positive logic is easier to read than negative logic.  My preference would be to compute DirectMovable and use !DirectMovable here instead.


Repository:
  rL LLVM

http://reviews.llvm.org/D12596