[PATCH] D12559: Fix IRBuilder CreateBitOrPointerCast for vector types

[Michael Zolotukhin via llvm-commits]

mzolotukhin added a subscriber: mzolotukhin.
mzolotukhin requested changes to this revision.
mzolotukhin added a reviewer: mzolotukhin.
mzolotukhin added a comment.
This revision now requires changes to proceed.

Hi Silviu,

What was the assertion and why didn't we get it when you tested specs before? Is the data that you posted before on the performance/code size/compile time still valid?

Thanks,
Michael


================
Comment at: include/llvm/IR/IRBuilder.h:1355
@@ -1354,3 +1354,3 @@
                                 const Twine &Name = "") {
-    if (V->getType() == DestTy)
+    if (V->getType()->getScalarType() == DestTy->getScalarType())
       return V;
----------------
This doesn't look right. What if we have vectors of different sizes (i.e. `V` is `<8 x i32>` and `DestTy` is `<4 x i32>`)?


http://reviews.llvm.org/D12559