[PATCH] D12559: Fix IRBuilder CreateBitOrPointerCast for vector types

Renato Golin via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 2 14:59:07 PDT 2015


rengolin added a subscriber: rengolin.
rengolin accepted this revision.
rengolin added a reviewer: rengolin.
rengolin added a comment.
This revision is now accepted and ready to land.

LGTM, too.

A test case might be hard to produce, but I can give you four candidates:

- Your original spec, anonymized
- Clang (see our self-hosting bots)
- Android (see Eugenis bot)
- Possibly PAQ8p on AArch64 (see our self-hosting bots)

Because this patch is the solution to broken bots, I accept it going as is, without test, for now.

Because the original patch did not break our bots straight away (on self-hosting clang), I think it triggers more Clang-alignment problems, but that's for a different investigation.

Please commit. You can work on the test on a subsequent commit.

cheers,
--reanato


http://reviews.llvm.org/D12559





More information about the llvm-commits mailing list