[llvm] r246531 - cmake: Error instead of warning and dropping invalid LLVM_USE_SANITIZER

[Filipe Cabecinhas via llvm-commits]

Thanks, that's much better!

  Filipe

On Monday, August 31, 2015, Justin Bogner via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Author: bogner
> Date: Tue Sep  1 00:45:07 2015
> New Revision: 246531
>
> URL: http://llvm.org/viewvc/llvm-project?rev=246531&view=rev
> Log:
> cmake: Error instead of warning and dropping invalid LLVM_USE_SANITIZER
>
> Currently, if you call cmake with a typo in an LLVM_USE_SANITIZER
> value, there's a cmake warning and the build goes on with no
> sanitizers at all. This isn't a good behaviour, since cmake warnings
> are fairly easy to miss and the resulting behaviour is that it looks
> like the build is sanitizer clean.
>
> Upgrade these warnings to errors so misconfigurations are more
> obvious.
>
> Modified:
>     llvm/trunk/cmake/modules/HandleLLVMOptions.cmake
>
> Modified: llvm/trunk/cmake/modules/HandleLLVMOptions.cmake
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/cmake/modules/HandleLLVMOptions.cmake?rev=246531&r1=246530&r2=246531&view=diff
>
> ==============================================================================
> --- llvm/trunk/cmake/modules/HandleLLVMOptions.cmake (original)
> +++ llvm/trunk/cmake/modules/HandleLLVMOptions.cmake Tue Sep  1 00:45:07
> 2015
> @@ -507,17 +507,17 @@ if(LLVM_USE_SANITIZER)
>        append("-fsanitize=address,undefined -fno-sanitize=vptr,function
> -fno-sanitize-recover=all"
>                CMAKE_C_FLAGS CMAKE_CXX_FLAGS)
>      else()
> -      message(WARNING "Unsupported value of LLVM_USE_SANITIZER:
> ${LLVM_USE_SANITIZER}")
> +      message(FATAL_ERROR "Unsupported value of LLVM_USE_SANITIZER:
> ${LLVM_USE_SANITIZER}")
>      endif()
>    elseif(MSVC)
>      if (LLVM_USE_SANITIZER STREQUAL "Address")
>        append_common_sanitizer_flags()
>        append("-fsanitize=address" CMAKE_C_FLAGS CMAKE_CXX_FLAGS)
>      else()
> -      message(WARNING "This sanitizer not yet supported in the MSVC
> environment: ${LLVM_USE_SANITIZER}")
> +      message(FATAL_ERROR "This sanitizer not yet supported in the MSVC
> environment: ${LLVM_USE_SANITIZER}")
>      endif()
>    else()
> -    message(WARNING "LLVM_USE_SANITIZER is not supported on this
> platform.")
> +    message(FATAL_ERROR "LLVM_USE_SANITIZER is not supported on this
> platform.")
>    endif()
>    if (LLVM_USE_SANITIZE_COVERAGE)
>
>  append("-fsanitize-coverage=edge,indirect-calls,8bit-counters,trace-cmp"
> CMAKE_C_FLAGS CMAKE_CXX_FLAGS)
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org <javascript:;>
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>


-- 
  F
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150901/46ab7831/attachment.html>