Thanks, that's much better!<div><br></div><div>  Filipe<br><br>On Monday, August 31, 2015, Justin Bogner via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: bogner<br>
Date: Tue Sep  1 00:45:07 2015<br>
New Revision: 246531<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=246531&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=246531&view=rev</a><br>
Log:<br>
cmake: Error instead of warning and dropping invalid LLVM_USE_SANITIZER<br>
<br>
Currently, if you call cmake with a typo in an LLVM_USE_SANITIZER<br>
value, there's a cmake warning and the build goes on with no<br>
sanitizers at all. This isn't a good behaviour, since cmake warnings<br>
are fairly easy to miss and the resulting behaviour is that it looks<br>
like the build is sanitizer clean.<br>
<br>
Upgrade these warnings to errors so misconfigurations are more<br>
obvious.<br>
<br>
Modified:<br>
    llvm/trunk/cmake/modules/HandleLLVMOptions.cmake<br>
<br>
Modified: llvm/trunk/cmake/modules/HandleLLVMOptions.cmake<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/cmake/modules/HandleLLVMOptions.cmake?rev=246531&r1=246530&r2=246531&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/cmake/modules/HandleLLVMOptions.cmake?rev=246531&r1=246530&r2=246531&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/cmake/modules/HandleLLVMOptions.cmake (original)<br>
+++ llvm/trunk/cmake/modules/HandleLLVMOptions.cmake Tue Sep  1 00:45:07 2015<br>
@@ -507,17 +507,17 @@ if(LLVM_USE_SANITIZER)<br>
       append("-fsanitize=address,undefined -fno-sanitize=vptr,function -fno-sanitize-recover=all"<br>
               CMAKE_C_FLAGS CMAKE_CXX_FLAGS)<br>
     else()<br>
-      message(WARNING "Unsupported value of LLVM_USE_SANITIZER: ${LLVM_USE_SANITIZER}")<br>
+      message(FATAL_ERROR "Unsupported value of LLVM_USE_SANITIZER: ${LLVM_USE_SANITIZER}")<br>
     endif()<br>
   elseif(MSVC)<br>
     if (LLVM_USE_SANITIZER STREQUAL "Address")<br>
       append_common_sanitizer_flags()<br>
       append("-fsanitize=address" CMAKE_C_FLAGS CMAKE_CXX_FLAGS)<br>
     else()<br>
-      message(WARNING "This sanitizer not yet supported in the MSVC environment: ${LLVM_USE_SANITIZER}")<br>
+      message(FATAL_ERROR "This sanitizer not yet supported in the MSVC environment: ${LLVM_USE_SANITIZER}")<br>
     endif()<br>
   else()<br>
-    message(WARNING "LLVM_USE_SANITIZER is not supported on this platform.")<br>
+    message(FATAL_ERROR "LLVM_USE_SANITIZER is not supported on this platform.")<br>
   endif()<br>
   if (LLVM_USE_SANITIZE_COVERAGE)<br>
     append("-fsanitize-coverage=edge,indirect-calls,8bit-counters,trace-cmp" CMAKE_C_FLAGS CMAKE_CXX_FLAGS)<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="javascript:;" onclick="_e(event, 'cvml', 'llvm-commits@lists.llvm.org')">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br><br>-- <br>  F<br><br>