[PATCH] D12459: Implement selective bitcode linking and internalization of linked symbols

[Artem Belevich via llvm-commits]

Hi,

On Fri, Aug 28, 2015 at 6:45 PM, Duncan P. N. Exon Smith <
dexonsmith at apple.com> wrote:

>
> > Index: tools/llvm-link/llvm-link.cpp
> > ===================================================================
> > --- tools/llvm-link/llvm-link.cpp
> > +++ tools/llvm-link/llvm-link.cpp
> > @@ -1249,6 +1260,11 @@
> >  bool ModuleLinker::linkGlobalValueBody(GlobalValue &Src) {
> >    Value *Dst = ValueMap[&Src];
> >    assert(Dst);
> > +  if (shouldInternalizeLinkedSymbols())
> > +    if (auto *DGV = dyn_cast<GlobalValue>(Dst)) {
> > +      DGV->setVisibility(GlobalValue::DefaultVisibility);
>
> Isn't visibility set to 'default' by `setLinkage()`?
>
>
You are correct. setLinkage(InternalLinkage) is sufficient. Fixed.


> > +      DGV->setLinkage(GlobalValue::InternalLinkage);
> > +    }
>


-- 
--Artem Belevich
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150831/c595e976/attachment.html>