<div dir="ltr"><div class="gmail_extra">Hi,</div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Aug 28, 2015 at 6:45 PM, Duncan P. N. Exon Smith <span dir="ltr"><<a href="mailto:dexonsmith@apple.com" target="_blank">dexonsmith@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><br>
> Index: tools/llvm-link/llvm-link.cpp<br>
> ===================================================================<br>
> --- tools/llvm-link/llvm-link.cpp<br>
> +++ tools/llvm-link/llvm-link.cpp<br>
> @@ -1249,6 +1260,11 @@<br>
>  bool ModuleLinker::linkGlobalValueBody(GlobalValue &Src) {<br>
>    Value *Dst = ValueMap[&Src];<br>
>    assert(Dst);<br>
> +  if (shouldInternalizeLinkedSymbols())<br>
> +    if (auto *DGV = dyn_cast<GlobalValue>(Dst)) {<br>
> +      DGV->setVisibility(GlobalValue::DefaultVisibility);<br>
<br>
Isn't visibility set to 'default' by `setLinkage()`?<br>
<br></blockquote><div><br></div><div>You are correct. setLinkage(InternalLinkage) is sufficient. Fixed.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
> +      DGV->setLinkage(GlobalValue::InternalLinkage);<br>
> +    }<br></blockquote></div><br clear="all"><div><br></div>-- <br><div><div dir="ltr">--Artem Belevich</div></div>
</div></div>