[PATCH] D11856: LowerBitSets: Extend pass to support functions as bitset members.

Kostya Serebryany via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 26 16:10:54 PDT 2015


kcc added inline comments.

================
Comment at: lib/Transforms/IPO/LowerBitSets.cpp:725
@@ +724,3 @@
+  // To create a jump table for these functions, we pick one function
+  // arbitrarily (say, f) and instruct the LLVM code generator to output a jump
+  // table immediately before f's instructions. This is done by representing the
----------------
Why do we do this? 

Yes, this will reduce the size of the jump table by 8 bytes, 
but is this optimization worth the extra complexity? 
We must try to be as simple as possible 



http://reviews.llvm.org/D11856





More information about the llvm-commits mailing list