[PATCH] D11856: LowerBitSets: Extend pass to support functions as bitset members.

[Peter Collingbourne via llvm-commits]

pcc added a comment.

> Maybe you could add a high-level algorithm description in the comments?


Done


================
Comment at: docs/BitSets.rst:33
@@ +32,3 @@
+of the function it jumps to, and for functions that are defined by the module
+this is reflected in the object's symbol table.
+
----------------
kcc wrote:
> jump table feels like a key concept here and deserves a separate paragraph with some more details,
> maybe even an illustration
Done,

================
Comment at: test/Transforms/LowerBitSets/function-ext.ll:1
@@ +1,2 @@
+; RUN: opt -S -lowerbitsets < %s | FileCheck %s
+
----------------
kcc wrote:
> here and below, please add tests explaining what we are testing for 
Done


http://reviews.llvm.org/D11856