[llvm] r246075 - SelectionDAGBuilder: Fix SPDescriptor not resetting GuardReg

[Matthias Braun via llvm-commits]

Author: matze
Date: Wed Aug 26 15:46:52 2015
New Revision: 246075

URL: http://llvm.org/viewvc/llvm-project?rev=246075&view=rev
Log:
SelectionDAGBuilder: Fix SPDescriptor not resetting GuardReg

This was causing problems when some functions use a GuardReg and some
don't as can happen when mixing SelectionDAG and FastISel generated
functions.

Added:
    llvm/trunk/test/CodeGen/X86/fast-isel-stackcheck.ll
Modified:
    llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.h

Modified: llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.h?rev=246075&r1=246074&r2=246075&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.h (original)
+++ llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.h Wed Aug 26 15:46:52 2015
@@ -516,6 +516,7 @@ private:
     void resetPerFunctionState() {
       FailureMBB = nullptr;
       Guard = nullptr;
+      GuardReg = 0;
     }
 
     MachineBasicBlock *getParentMBB() { return ParentMBB; }

Added: llvm/trunk/test/CodeGen/X86/fast-isel-stackcheck.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/fast-isel-stackcheck.ll?rev=246075&view=auto
==============================================================================
--- llvm/trunk/test/CodeGen/X86/fast-isel-stackcheck.ll (added)
+++ llvm/trunk/test/CodeGen/X86/fast-isel-stackcheck.ll Wed Aug 26 15:46:52 2015
@@ -0,0 +1,44 @@
+; RUN: llc -o - %s | FileCheck %s
+target datalayout = "e-m:o-i64:64-f80:128-n8:16:32:64-S128"
+target triple = "x86_64-apple-macosx"
+
+; selectiondag stack protector uses a GuardReg which the fast-isel stack
+; protection code did not but the state was not reset properly.
+; The optnone attribute on @bar forces fast-isel.
+
+; CHECK-LABEL: foo:
+; CHECK: movq ___stack_chk_guard at GOTPCREL(%rip), %rax
+; CHECK-NOT: movq ___stack_chk_guard at GOTPCREL(%rip), %rax
+define void @foo() #0 {
+entry:
+  %_tags = alloca [3 x i32], align 4
+  ret void
+}
+
+; CHECK-LABEL: bar:
+; CHECK: movq ___stack_chk_guard at GOTPCREL(%rip), %rax
+; CHECK: movq ___stack_chk_guard at GOTPCREL(%rip), %rax
+define void @bar() #1 {
+entry:
+  %vt = alloca [2 x double], align 16
+  br i1 undef, label %cleanup.4091, label %for.cond.3850
+
+unreachable:
+  unreachable
+
+for.cond.3850:
+  br i1 undef, label %land.rhs.3853, label %land.end.3857
+
+land.rhs.3853:
+  br label %land.end.3857
+
+land.end.3857:
+  %0 = phi i1 [ false, %for.cond.3850 ], [ false, %land.rhs.3853 ]
+  br i1 %0, label %unreachable, label %unreachable
+
+cleanup.4091:
+  ret void
+}
+
+attributes #0 = { ssp }
+attributes #1 = { noinline optnone ssp }