[PATCH] D12153: Support inline functions symbolization in Addr2Line symbolizer.

[Yury Gribov via llvm-commits]

ygribov added inline comments.

================
Comment at: lib/asan/scripts/asan_symbolize.py:163
@@ +162,3 @@
+      frame = 0
+      while True:
+        function_name = self.pipe.stdout.readline().rstrip()
----------------
m.ostepenko wrote:
> ygribov wrote:
> > Perhaps add a guard here to avoid endless loop?
> I did this in my previous revision, but Alexey wrote this in previous comment:
> 
> > Why can't this be while-true loop?
> 
> So, I'm a bit confused, what approach is preferable here.
Yeah, I'm a bit worried about corner-cases causing our primitive parser to hang but that may be an overkill.


http://reviews.llvm.org/D12153