[PATCH] D12153: Support inline functions symbolization in Addr2Line symbolizer.

[Maxim Ostapenko via llvm-commits]

m.ostepenko added inline comments.

================
Comment at: lib/asan/scripts/asan_symbolize.py:163
@@ +162,3 @@
+      frame = 0
+      while True:
+        function_name = self.pipe.stdout.readline().rstrip()
----------------
ygribov wrote:
> Perhaps add a guard here to avoid endless loop?
I did this in my previous revision, but Alexey wrote this in previous comment:

> Why can't this be while-true loop?

So, I'm a bit confused, what approach is preferable here.

================
Comment at: lib/sanitizer_common/sanitizer_symbolizer_posix_libcdep.cc:219
@@ -218,2 +218,3 @@
   const char *module_name_;  // Owned, leaked.
+  static const char output_terminator_[9];
 };
----------------
ygribov wrote:
> You don't need 9, neither here, nor in definition.
Hm, without 9 I got this:

```
/home/max/src/llvm/projects/compiler-rt/lib/sanitizer_common/sanitizer_symbolizer_posix_libcdep.cc:198:41: error: invalid application of 'sizeof' to an incomplete type 'const char []'
    const size_t terminator_len = sizeof(output_terminator_) - 1;
                                        ^~~~~~~~~~~~~~~~~~~~
1 error generated.
```


http://reviews.llvm.org/D12153