[PATCH] D12279: [mips][microMIPS] Implement ADDIUR1SP, ADDIUR2, ADDIUS5 and ADDIUSP instructions

Vedant Kumar via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 24 17:20:14 PDT 2015


vsk added a subscriber: vsk.
vsk added a comment.

I have one nit (inline). Could you add a test as well?


================
Comment at: lib/Target/Mips/Disassembler/MipsDisassembler.cpp:841
@@ +840,3 @@
+      DEBUG(dbgs() << "Trying MicroMipsR616 table (16-bit instructions):\n");
+      // Calling the auto-generated decoder function.
+      Result = decodeInstruction(DecoderTableMicroMipsR616, Instr, Insn,
----------------
This comment is identical to the one of line 846. Could you reference the fact that you are calling auto-generated decoder functions once (maybe before the if)?


http://reviews.llvm.org/D12279





More information about the llvm-commits mailing list