[llvm] r245549 - Make helper functions static. NFC.

[David Blaikie via llvm-commits]

On Thu, Aug 20, 2015 at 2:57 AM, Benjamin Kramer via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Author: d0k
> Date: Thu Aug 20 04:57:22 2015
> New Revision: 245549
>
> URL: http://llvm.org/viewvc/llvm-project?rev=245549&view=rev
> Log:
> Make helper functions static. NFC.
>

Sorry, I'm sure I've asked this before (& no doubt you've answered): How
impractical would it be to turn on -Wmissing-prototype for the LLVM (&
Clang, etc) build? (be fun to make -Wmissing-prototype or a similar warning
for classes too)

(& maybe -Wweak-vtables - just thinking of other coding-convention-esque
warnings (though that's a somewhat 'weak' (har har) coding convention
anyway, probably lots of cleanup & little benefit I bet))


>
> Modified:
>     llvm/trunk/lib/CodeGen/PeepholeOptimizer.cpp
>     llvm/trunk/lib/Transforms/Scalar/LoopUnrollPass.cpp
>
> Modified: llvm/trunk/lib/CodeGen/PeepholeOptimizer.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/PeepholeOptimizer.cpp?rev=245549&r1=245548&r2=245549&view=diff
>
> ==============================================================================
> --- llvm/trunk/lib/CodeGen/PeepholeOptimizer.cpp (original)
> +++ llvm/trunk/lib/CodeGen/PeepholeOptimizer.cpp Thu Aug 20 04:57:22 2015
> @@ -721,7 +721,7 @@ bool PeepholeOptimizer::findNextSource(u
>  /// successfully traverse a PHI instruction and find suitable sources
> coming
>  /// from its edges. By inserting a new PHI, we provide a rewritten PHI def
>  /// suitable to be used in a new COPY instruction.
> -MachineInstr *
> +static MachineInstr *
>  insertPHI(MachineRegisterInfo *MRI, const TargetInstrInfo *TII,
>            const SmallVectorImpl<TargetInstrInfo::RegSubRegPair> &SrcRegs,
>            MachineInstr *OrigPHI) {
>
> Modified: llvm/trunk/lib/Transforms/Scalar/LoopUnrollPass.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/LoopUnrollPass.cpp?rev=245549&r1=245548&r2=245549&view=diff
>
> ==============================================================================
> --- llvm/trunk/lib/Transforms/Scalar/LoopUnrollPass.cpp (original)
> +++ llvm/trunk/lib/Transforms/Scalar/LoopUnrollPass.cpp Thu Aug 20
> 04:57:22 2015
> @@ -518,7 +518,7 @@ struct EstimatedUnrollCost {
>  /// \returns Optional value, holding the RolledDynamicCost and
> UnrolledCost. If
>  /// the analysis failed (no benefits expected from the unrolling, or the
> loop is
>  /// too big to analyze), the returned value is None.
> -Optional<EstimatedUnrollCost>
> +static Optional<EstimatedUnrollCost>
>  analyzeLoopUnrollCost(const Loop *L, unsigned TripCount, DominatorTree
> &DT,
>                        ScalarEvolution &SE, const TargetTransformInfo &TTI,
>                        int MaxUnrolledLoopSize) {
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150820/ca8f2ce4/attachment.html>