<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Aug 20, 2015 at 2:57 AM, Benjamin Kramer via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: d0k<br>
Date: Thu Aug 20 04:57:22 2015<br>
New Revision: 245549<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=245549&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=245549&view=rev</a><br>
Log:<br>
Make helper functions static. NFC.<br></blockquote><div><br>Sorry, I'm sure I've asked this before (& no doubt you've answered): How impractical would it be to turn on -Wmissing-prototype for the LLVM (& Clang, etc) build? (be fun to make -Wmissing-prototype or a similar warning for classes too)<br><br>(& maybe -Wweak-vtables - just thinking of other coding-convention-esque warnings (though that's a somewhat 'weak' (har har) coding convention anyway, probably lots of cleanup & little benefit I bet))<br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Modified:<br>
    llvm/trunk/lib/CodeGen/PeepholeOptimizer.cpp<br>
    llvm/trunk/lib/Transforms/Scalar/LoopUnrollPass.cpp<br>
<br>
Modified: llvm/trunk/lib/CodeGen/PeepholeOptimizer.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/PeepholeOptimizer.cpp?rev=245549&r1=245548&r2=245549&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/PeepholeOptimizer.cpp?rev=245549&r1=245548&r2=245549&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/CodeGen/PeepholeOptimizer.cpp (original)<br>
+++ llvm/trunk/lib/CodeGen/PeepholeOptimizer.cpp Thu Aug 20 04:57:22 2015<br>
@@ -721,7 +721,7 @@ bool PeepholeOptimizer::findNextSource(u<br>
 /// successfully traverse a PHI instruction and find suitable sources coming<br>
 /// from its edges. By inserting a new PHI, we provide a rewritten PHI def<br>
 /// suitable to be used in a new COPY instruction.<br>
-MachineInstr *<br>
+static MachineInstr *<br>
 insertPHI(MachineRegisterInfo *MRI, const TargetInstrInfo *TII,<br>
           const SmallVectorImpl<TargetInstrInfo::RegSubRegPair> &SrcRegs,<br>
           MachineInstr *OrigPHI) {<br>
<br>
Modified: llvm/trunk/lib/Transforms/Scalar/LoopUnrollPass.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/LoopUnrollPass.cpp?rev=245549&r1=245548&r2=245549&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/LoopUnrollPass.cpp?rev=245549&r1=245548&r2=245549&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Transforms/Scalar/LoopUnrollPass.cpp (original)<br>
+++ llvm/trunk/lib/Transforms/Scalar/LoopUnrollPass.cpp Thu Aug 20 04:57:22 2015<br>
@@ -518,7 +518,7 @@ struct EstimatedUnrollCost {<br>
 /// \returns Optional value, holding the RolledDynamicCost and UnrolledCost. If<br>
 /// the analysis failed (no benefits expected from the unrolling, or the loop is<br>
 /// too big to analyze), the returned value is None.<br>
-Optional<EstimatedUnrollCost><br>
+static Optional<EstimatedUnrollCost><br>
 analyzeLoopUnrollCost(const Loop *L, unsigned TripCount, DominatorTree &DT,<br>
                       ScalarEvolution &SE, const TargetTransformInfo &TTI,<br>
                       int MaxUnrolledLoopSize) {<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>