[PATCH] D12161: [compiler-rt] Add aarch64 syscall optimization support

Renato Golin via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 20 10:15:21 PDT 2015


rengolin added inline comments.

================
Comment at: lib/sanitizer_common/sanitizer_syscall_linux_aarch64.inc:131
@@ +130,3 @@
+
+bool internal_iserror(uptr retval, int *rverrno) {
+  if (retval >= (uptr)-4095) {
----------------
zatrazz wrote:
> rengolin wrote:
> > Some comments about this would be welcome.
> This is the default return code Linux assumes for syscall failures (you can check on libc projects, like glibc and must, that they use the same return check value).
I mean, on the code. :)


http://reviews.llvm.org/D12161





More information about the llvm-commits mailing list