[PATCH] D12161: [compiler-rt] Add aarch64 syscall optimization support

Adhemerval Zanella via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 20 10:02:14 PDT 2015


zatrazz added a comment.

The test is basically run the sanitizers tests and check for regression, since all internal syscalls will use the wrappers instead of normal syscall libc function.


================
Comment at: lib/sanitizer_common/sanitizer_syscall_linux_aarch64.inc:131
@@ +130,3 @@
+
+bool internal_iserror(uptr retval, int *rverrno) {
+  if (retval >= (uptr)-4095) {
----------------
rengolin wrote:
> Some comments about this would be welcome.
This is the default return code Linux assumes for syscall failures (you can check on libc projects, like glibc and must, that they use the same return check value).


http://reviews.llvm.org/D12161





More information about the llvm-commits mailing list