[PATCH] D11710: [DSE] Enable removal of lifetime intrinsics in terminating blocks

[Philip Reames via llvm-commits]

Interesting.  Definitely not an interaction I saw coming.  Do you have 
any thoughts on how to address?  I'm assuming we need to tweak the 
inliner's logic here, but I'm not familiar enough with the code in 
question to give good suggestions.

Philip

On 08/20/2015 02:09 AM, Björn Steinbrink wrote:
> dotdash added a comment.
>
> I had to revert this because it caused test failures in clang, which made me realize that this interacts badly with inlining as it is. The inliner only adds lifetime intrinsics for an inlined alloca if there are no lifetime intrinsics for this alloca at all. But with this patch, we can end up with an alloca that only has a lifetime start but no end. In that case, the inliner wouldn't add lifetime intrinsics, leading to worse stack coloring than before.
>
>
> Repository:
>    rL LLVM
>
> http://reviews.llvm.org/D11710
>
>
>