[PATCH] D11710: [DSE] Enable removal of lifetime intrinsics in terminating blocks

Björn Steinbrink via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 20 02:09:33 PDT 2015


dotdash added a comment.

I had to revert this because it caused test failures in clang, which made me realize that this interacts badly with inlining as it is. The inliner only adds lifetime intrinsics for an inlined alloca if there are no lifetime intrinsics for this alloca at all. But with this patch, we can end up with an alloca that only has a lifetime start but no end. In that case, the inliner wouldn't add lifetime intrinsics, leading to worse stack coloring than before.


Repository:
  rL LLVM

http://reviews.llvm.org/D11710





More information about the llvm-commits mailing list