[PATCH] D12094: Avoid the propagation of debug locations in SelectionDAG via CSE
Sergey Dmitrouk via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 18 03:02:43 PDT 2015
sdmitrouk added a comment.
Hi,
Are there any reasons to implement the check in separate function instead of
changing 3-argument overload of `SelectionDAG::FindNodeOrInsertPos` to handle
nodes of all kinds (that would require updating its comment a bit)? If I
counted correctly, the changes cover 20 of 27 uses of that overload and it might
make sense to keep debug location erasure in one place to make it less
error-prone, unless there are reasons not to do this.
Regards,
Sergey
http://reviews.llvm.org/D12094
More information about the llvm-commits
mailing list