[PATCH] D12094: Avoid the propagation of debug locations in SelectionDAG via CSE

Wolfgang Pieb via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 17 18:02:10 PDT 2015


wolfgangp created this revision.
wolfgangp added reviewers: echristo, sdmitrouk.
wolfgangp added a subscriber: llvm-commits.

When SelectionDAG performs CSE it is possible that the context's source location is different from that of the selected node. This can lead to incorrect line number records. This patch proposes to null out the location if this occurs, in order to address PR21006 (oscillating line number records due to CSE performed on constant pool loads).

Note that r237237 is doing something similar for Constants. It seems necessary to extend it to all nodes.

http://reviews.llvm.org/D12094

Files:
  include/llvm/CodeGen/SelectionDAG.h
  lib/CodeGen/SelectionDAG/SelectionDAG.cpp
  test/DebugInfo/isel-cse-line.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D12094.32358.patch
Type: text/x-patch
Size: 13365 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150818/85e2d137/attachment.bin>


More information about the llvm-commits mailing list