[PATCH] D11596: Separate out BDCE's analysis into a separate DemandedBits analysis.

[hfinkel@anl.gov via llvm-commits]

hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.

One comment below, otherwise LGTM.


================
Comment at: lib/Transforms/Scalar/BDCE.cpp:94
@@ -390,7 +93,3 @@
 
-    if (isAlwaysLive(&I))
-      continue;
-
-    Worklist.push_back(&I);
-    I.dropAllReferences();
-    Changed = true;
+    if (!isAlwaysLive(&I)) {
+      Worklist.push_back(&I);
----------------
You don't need this check here because you also have the isAlwaysLive check in DB.isInstructionDead (and I think that's a good thing).



Repository:
  rL LLVM

http://reviews.llvm.org/D11596