[PATCH] D11596: Separate out BDCE's analysis into a separate DemandedBits analysis.

[James Molloy via llvm-commits]

jmolloy updated this revision to Diff 32039.
jmolloy added a comment.

Hi Hal,

I worked out where I was getting confused. In DemandedBits, the "Visited" set only contains non-integer instructions. In "isInstructionDead" I was only visiting membership of the Visited set - I needed to check membership of AliveBits too because that's where all the integer types live.

With that change, I've been able to do away with a no-longer needed API function and the code looks a lot neater.

Cheers,

James


Repository:
  rL LLVM

http://reviews.llvm.org/D11596

Files:
  include/llvm/Analysis/DemandedBits.h
  include/llvm/InitializePasses.h
  lib/Analysis/Analysis.cpp
  lib/Analysis/CMakeLists.txt
  lib/Analysis/DemandedBits.cpp
  lib/Transforms/Scalar/BDCE.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D11596.32039.patch
Type: text/x-patch
Size: 32536 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150813/b734faa5/attachment.bin>