[PATCH] llvm-build: Adopt generation of LLVM_LIBS_TO_EXPORT
Brad King via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 13 11:46:59 PDT 2015
On 08/13/2015 02:27 PM, Dan Liew wrote:
> I'm not so sure about patch 0003.
>
> Rather than special casing for gtest_* in LLVMBuild's code wouldn't it
> make more sense to use the existing ``installed = 0`` attribute in
> ``utils/unittest/LLVMBuild.txt`` to tell the relevant method to not
> emit that component into ``LLVM_LIBS_TO_EXPORT``?
Yes, that makes sense. However, I'm not familiar enough with the
infrastructure to do it that way. I'd be happy to review such an
alternative patch though.
Thanks,
-Brad
More information about the llvm-commits
mailing list