[PATCH] llvm-build: Adopt generation of LLVM_LIBS_TO_EXPORT

Dan Liew via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 13 11:27:50 PDT 2015


Hi Brad,

Sorry for taking so long to take a long at this. Patch 0001 and 0002 look fine.

I'm not so sure about patch 0003.

Rather than special casing for gtest_* in LLVMBuild's code wouldn't it
make more sense to use the existing ``installed = 0`` attribute in
``utils/unittest/LLVMBuild.txt`` to tell the relevant method to not
emit that component into ``LLVM_LIBS_TO_EXPORT``?

That way the approach is general so if additional components (that are
libraries) are introduced in the future that are marked as ``installed
= 0`` then those will also be excluded from ``LLVM_LIBS_TO_EXPORT``.

Thanks,
Dan.


More information about the llvm-commits mailing list