[compiler-rt] r244786 - Try to fix the MSVC build now that we use /Zc:inline.

Kostya Serebryany via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 12 14:52:21 PDT 2015


I wonder if you can move the ifdef magic into a header file (
sanitizer_internal_defs.h)
Having ifdefs throughout the code is really annoying.

On Wed, Aug 12, 2015 at 11:09 AM, Rafael Espindola via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Author: rafael
> Date: Wed Aug 12 13:09:44 2015
> New Revision: 244786
>
> URL: http://llvm.org/viewvc/llvm-project?rev=244786&view=rev
> Log:
> Try to fix the MSVC build now that we use /Zc:inline.
>
> Thanks to Majnemer for the help.
>
> Modified:
>     compiler-rt/trunk/lib/asan/asan_fake_stack.cc
>
> Modified: compiler-rt/trunk/lib/asan/asan_fake_stack.cc
> URL:
> http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/asan/asan_fake_stack.cc?rev=244786&r1=244785&r2=244786&view=diff
>
> ==============================================================================
> --- compiler-rt/trunk/lib/asan/asan_fake_stack.cc (original)
> +++ compiler-rt/trunk/lib/asan/asan_fake_stack.cc Wed Aug 12 13:09:44 2015
> @@ -80,7 +80,9 @@ void FakeStack::PoisonAll(u8 magic) {
>                 magic);
>  }
>
> +#if !defined(_MSC_VER) || defined(__clang__)
>  ALWAYS_INLINE USED
> +#endif
>  FakeFrame *FakeStack::Allocate(uptr stack_size_log, uptr class_id,
>                                 uptr real_stack) {
>    CHECK_LT(class_id, kNumberOfSizeClasses);
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150812/a10ff178/attachment.html>


More information about the llvm-commits mailing list