<div dir="ltr">I wonder if you can move the ifdef magic into a header file (<span style="color:rgb(0,0,0)">sanitizer_internal_defs.h</span>)<br><div>Having ifdefs throughout the code is really annoying. </div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Aug 12, 2015 at 11:09 AM, Rafael Espindola via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: rafael<br>
Date: Wed Aug 12 13:09:44 2015<br>
New Revision: 244786<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=244786&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=244786&view=rev</a><br>
Log:<br>
Try to fix the MSVC build now that we use /Zc:inline.<br>
<br>
Thanks to Majnemer for the help.<br>
<br>
Modified:<br>
    compiler-rt/trunk/lib/asan/asan_fake_stack.cc<br>
<br>
Modified: compiler-rt/trunk/lib/asan/asan_fake_stack.cc<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/asan/asan_fake_stack.cc?rev=244786&r1=244785&r2=244786&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/asan/asan_fake_stack.cc?rev=244786&r1=244785&r2=244786&view=diff</a><br>
==============================================================================<br>
--- compiler-rt/trunk/lib/asan/asan_fake_stack.cc (original)<br>
+++ compiler-rt/trunk/lib/asan/asan_fake_stack.cc Wed Aug 12 13:09:44 2015<br>
@@ -80,7 +80,9 @@ void FakeStack::PoisonAll(u8 magic) {<br>
                magic);<br>
 }<br>
<br>
+#if !defined(_MSC_VER) || defined(__clang__)<br>
 ALWAYS_INLINE USED<br>
+#endif<br>
 FakeFrame *FakeStack::Allocate(uptr stack_size_log, uptr class_id,<br>
                                uptr real_stack) {<br>
   CHECK_LT(class_id, kNumberOfSizeClasses);<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>