[PATCH] D11722: [ThinLTO] Bitcode reading/writing support for ThinLTO function summary/index

[Teresa Johnson via llvm-commits]

tejohnson added a comment.

In http://reviews.llvm.org/D11722#223090, @reames wrote:

> Can you add references to the relevant RFCs to the review descriptions?  It's getting hard to track all the pieces.  My main comments can be found in the linked review for the data structures.


Will do.


================
Comment at: include/llvm/Bitcode/ReaderWriter.h:70
@@ +69,3 @@
+  /// the index, otherwise skip the function summary section.
+  ErrorOr<std::unique_ptr<ThinLTOFunctionSummaryIndex>> getThinLTOIndex(
+      MemoryBufferRef Buffer, LLVMContext &Context,
----------------
reames wrote:
> As a general comment: this index really isn't a ThinkLTO*Index, it's a *Index for the bitcode that happens to be used for LTO.  The naming of the various methods and comments need to reflect that.
I responded to this suggestion in the review for D11721 as well - I didn't think this information would be used outside of ThinLTO importing decisions/mechanics. So thought it was better to name it accordingly. I'm open to changing the name, which currently also matches the names of the proposed bitcode sections.


http://reviews.llvm.org/D11722