[PATCH] D11722: [ThinLTO] Bitcode reading/writing support for ThinLTO function summary/index

[Philip Reames via llvm-commits]

reames added a subscriber: reames.
reames added a comment.

Can you add references to the relevant RFCs to the review descriptions?  It's getting hard to track all the pieces.  My main comments can be found in the linked review for the data structures.


================
Comment at: include/llvm/Bitcode/ReaderWriter.h:70
@@ +69,3 @@
+  /// the index, otherwise skip the function summary section.
+  ErrorOr<std::unique_ptr<ThinLTOFunctionSummaryIndex>> getThinLTOIndex(
+      MemoryBufferRef Buffer, LLVMContext &Context,
----------------
As a general comment: this index really isn't a ThinkLTO*Index, it's a *Index for the bitcode that happens to be used for LTO.  The naming of the various methods and comments need to reflect that.


http://reviews.llvm.org/D11722