[llvm] r242833 - Don't iterate over the program headers in the constructor of ELFFile.

[Dimitar Dobrev]

    This is our code: mono/CppSharp . Because of the change we can no longer upgrade the LLVM we use, and occasionally we need to. Of course, a helper function as you suggest that simply returns a list of the dependencies would work even better for us.
    Regards,
    Dimitar
|   |
|   |  |   |   |   |   |   |
| mono/CppSharpCppSharp - Tools to surface C++ APIs to C# |
|  |
| View on github.com | Preview by Yahoo |
|  |
|   |


 


     On Tuesday, August 4, 2015 1:29 AM, Rafael Espíndola <rafael.espindola at gmail.com> wrote:
   

 On 28 July 2015 at 11:22, Dimitar Dobrev <dpldobrev at yahoo.com> wrote:
>
>    Hi Rafael,
>
>    Is there any way the changes to ELF.h could be reverted? We used the
> deleted functions to get the dependencies of ELF binaries.
>    Now our code is broken.

The constructor should definitely not be iterating over the program
headers (or the sections, but I am still working on that).

This code path is used by *any* tool that opens an elf file, so it
should not have code that is used by just a few.

What is your program doing? Can it walk the program header like
llvm-readobj does? We could have a helper function in ELF.h that is
*not* called by the constructor, but it would be a bit odd if no in
tree tool uses it.

Cheers,
Rafael


  
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150803/9302d24b/attachment.html>