[llvm] r242833 - Don't iterate over the program headers in the constructor of ELFFile.

Rafael EspĂ­ndola rafael.espindola at gmail.com
Mon Aug 3 15:29:58 PDT 2015


On 28 July 2015 at 11:22, Dimitar Dobrev <dpldobrev at yahoo.com> wrote:
>
>     Hi Rafael,
>
>     Is there any way the changes to ELF.h could be reverted? We used the
> deleted functions to get the dependencies of ELF binaries.
>     Now our code is broken.

The constructor should definitely not be iterating over the program
headers (or the sections, but I am still working on that).

This code path is used by *any* tool that opens an elf file, so it
should not have code that is used by just a few.

What is your program doing? Can it walk the program header like
llvm-readobj does? We could have a helper function in ELF.h that is
*not* called by the constructor, but it would be a bit odd if no in
tree tool uses it.

Cheers,
Rafael



More information about the llvm-commits mailing list