[PATCH] D11365: [asan] Add a "dump_registers" flag to print out CPU registers after a SIGSEGV

Kuba Brecka kuba.brecka at gmail.com
Fri Jul 24 06:13:55 PDT 2015


kubabrecka updated this revision to Diff 30570.
kubabrecka added a comment.

> IMO you should either remove this line to not litter the output, or avoid enabling dump_registers by default...


Makes sense.  In that case it seems to me that it's better to just drop the flag altogether, and simply print this when it's implemented (OS X only for now).


http://reviews.llvm.org/D11365

Files:
  lib/asan/asan_report.cc
  lib/sanitizer_common/sanitizer_common.h
  lib/sanitizer_common/sanitizer_linux.cc
  lib/sanitizer_common/sanitizer_mac.cc
  lib/sanitizer_common/sanitizer_win.cc
  test/asan/TestCases/dump_registers.cc

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D11365.30570.patch
Type: text/x-patch
Size: 5226 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150724/2e581177/attachment.bin>


More information about the llvm-commits mailing list