[PATCH] D11365: [asan] Add a "dump_registers" flag to print out CPU registers after a SIGSEGV

[Alexey Samsonov]

samsonov added inline comments.

================
Comment at: lib/sanitizer_common/sanitizer_linux.cc:1102
@@ +1101,3 @@
+void SignalContext::DumpAllRegisters() const {
+  // FIXME: Implement this.
+  Printf("DumpAllRegisters is not implemented on this platform.\n");
----------------
IMO you should either remove this line to not litter the output, or avoid enabling `dump_registers` by default...

================
Comment at: lib/sanitizer_common/sanitizer_win.cc:663
@@ +662,3 @@
+  // FIXME: Implement this.
+  Printf("DumpAllRegisters is not implemented on this platform.\n");
+}
----------------
ditto


http://reviews.llvm.org/D11365