[llvm] r233722 - [Orc][MCJIT] Remove the small code model regression tests.

[Philip Reames]

I finally got around to filing this as:
https://llvm.org/bugs/show_bug.cgi?id=24159

On 04/09/2015 10:11 AM, Lang Hames wrote:
> Hi Philip,
>
> No - as far as I know there's no bug for this. Please go ahead and 
> file one. If we add a simple custom memory manager to llvm-rtdyld 
> that's compatible with the small memory model (maybe just reserve ~1Mb 
> up front? We'll never need more than that for regression tests). Then 
> we can add a flag to chose that memory manager and tests specifically 
> for small-code-model relocations.
>
> Cheers,
> Lang.
>
> On Thu, Apr 9, 2015 at 8:50 AM, Philip Reames 
> <listmail at philipreames.com <mailto:listmail at philipreames.com>> wrote:
>
>     Lang,
>
>     Is there a bug open for getting a small model memory manager
>     implemented and these tests restored?  I'd like to be able to
>     track the work on this.  If you're not going to get to it soon, I
>     might send a patch myself.  Supporting a small memory model is
>     something which is useful to me and I'm nervous that it's
>     currently untested in tree.
>
>     Philip
>
>
>     On 03/31/2015 11:19 AM, Lang Hames wrote:
>
>         Author: lhames
>         Date: Tue Mar 31 13:19:25 2015
>         New Revision: 233722
>
>         URL: http://llvm.org/viewvc/llvm-project?rev=233722&view=rev
>         Log:
>         [Orc][MCJIT] Remove the small code model regression tests.
>
>         These regression tests are supposed to test small code model
>         support, but have
>         been XFAIL'd because we don't have an in-tree memory manager
>         that can guarantee
>         a small-code-model compatible memory layout. Unfortunately,
>         they can
>         occasionally pass if they get lucky with memory allocation,
>         causing unexpected
>         passes on the bots. That's not very helpful.
>
>         I'm going to remove these until we have the infrastructure
>         (small-code-model
>         compatible memory manager) to run them properly.
>
>
>         Removed:
>              llvm/trunk/test/ExecutionEngine/MCJIT/hello-sm-pic.ll
>              llvm/trunk/test/ExecutionEngine/OrcMCJIT/hello-sm-pic.ll
>
>         Removed: llvm/trunk/test/ExecutionEngine/MCJIT/hello-sm-pic.ll
>         URL:
>         http://llvm.org/viewvc/llvm-project/llvm/trunk/test/ExecutionEngine/MCJIT/hello-sm-pic.ll?rev=233721&view=auto
>         ==============================================================================
>         --- llvm/trunk/test/ExecutionEngine/MCJIT/hello-sm-pic.ll
>         (original)
>         +++ llvm/trunk/test/ExecutionEngine/MCJIT/hello-sm-pic.ll
>         (removed)
>         @@ -1,12 +0,0 @@
>         -; RUN: %lli -relocation-model=pic -code-model=small %s >
>         /dev/null
>         -; XFAIL: mips, i686, i386, darwin, aarch64, arm
>         -
>         - at .LC0 = internal global [12 x i8] c"Hello World\00"          
>         ; <[12 x i8]*> [#uses=1]
>         -
>         -declare i32 @puts(i8*)
>         -
>         -define i32 @main() {
>         -       %reg210 = call i32 @puts( i8* getelementptr ([12 x
>         i8], [12 x i8]* @.LC0, i64 0, i64 0) )      ; <i32> [#uses=0]
>         -       ret i32 0
>         -}
>         -
>
>         Removed: llvm/trunk/test/ExecutionEngine/OrcMCJIT/hello-sm-pic.ll
>         URL:
>         http://llvm.org/viewvc/llvm-project/llvm/trunk/test/ExecutionEngine/OrcMCJIT/hello-sm-pic.ll?rev=233721&view=auto
>         ==============================================================================
>         --- llvm/trunk/test/ExecutionEngine/OrcMCJIT/hello-sm-pic.ll
>         (original)
>         +++ llvm/trunk/test/ExecutionEngine/OrcMCJIT/hello-sm-pic.ll
>         (removed)
>         @@ -1,12 +0,0 @@
>         -; RUN: %lli -jit-kind=orc-mcjit -relocation-model=pic
>         -code-model=small %s > /dev/null
>         -; XFAIL: mips, i686, i386, darwin, aarch64, arm
>         -
>         - at .LC0 = internal global [12 x i8] c"Hello World\00"          
>         ; <[12 x i8]*> [#uses=1]
>         -
>         -declare i32 @puts(i8*)
>         -
>         -define i32 @main() {
>         -       %reg210 = call i32 @puts( i8* getelementptr ([12 x
>         i8], [12 x i8]* @.LC0, i64 0, i64 0) )      ; <i32> [#uses=0]
>         -       ret i32 0
>         -}
>         -
>
>
>         _______________________________________________
>         llvm-commits mailing list
>         llvm-commits at cs.uiuc.edu <mailto:llvm-commits at cs.uiuc.edu>
>         http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150716/633f648e/attachment.html>