<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
I finally got around to filing this as:<br>
<a class="moz-txt-link-freetext" href="https://urldefense.proofpoint.com/v2/url?u=https-3A__llvm.org_bugs_show-5Fbug.cgi-3Fid-3D24159&d=AwMDaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=0FMbYu2NNIaloVe3XJYPMw0Y8mwKSncoWYfqpmqnTlw&s=dumsxmjOfNpzVIeVkwLzCNxvrnnAiFSbYtVVhtrHVvQ&e=">https://llvm.org/bugs/show_bug.cgi?id=24159</a><br>
<br>
<div class="moz-cite-prefix">On 04/09/2015 10:11 AM, Lang Hames
wrote:<br>
</div>
<blockquote
cite="mid:CALLttgpe+HR9TWAnbsXC3G9LpVeGZ2UG1DNd40vxABmjmbiRjQ@mail.gmail.com"
type="cite">
<div dir="ltr">Hi Philip,
<div><br>
</div>
<div>No - as far as I know there's no bug for this. Please go
ahead and file one. If we add a simple custom memory manager
to llvm-rtdyld that's compatible with the small memory model
(maybe just reserve ~1Mb up front? We'll never need more than
that for regression tests). Then we can add a flag to chose
that memory manager and tests specifically for
small-code-model relocations.</div>
<div><br>
</div>
<div>Cheers,</div>
<div>Lang.</div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Thu, Apr 9, 2015 at 8:50 AM, Philip
Reames <span dir="ltr"><<a moz-do-not-send="true" href="mailto:listmail@philipreames.com" target="_blank">listmail@philipreames.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">Lang,<br>
<br>
Is there a bug open for getting a small model memory manager
implemented and these tests restored? I'd like to be able
to track the work on this. If you're not going to get to it
soon, I might send a patch myself. Supporting a small
memory model is something which is useful to me and I'm
nervous that it's currently untested in tree.<span
class="HOEnZb"><font color="#888888"><br>
<br>
Philip</font></span>
<div class="HOEnZb">
<div class="h5"><br>
<br>
On 03/31/2015 11:19 AM, Lang Hames wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
Author: lhames<br>
Date: Tue Mar 31 13:19:25 2015<br>
New Revision: 233722<br>
<br>
URL: <a moz-do-not-send="true" href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D233722-26view-3Drev&d=AwMDaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=0FMbYu2NNIaloVe3XJYPMw0Y8mwKSncoWYfqpmqnTlw&s=DFOJHoyUoC4oMIe1uc5Fe_Tn5T2JvdMs0ZZJABchbyA&e=" target="_blank">http://llvm.org/viewvc/llvm-project?rev=233722&view=rev</a><br>
Log:<br>
[Orc][MCJIT] Remove the small code model regression
tests.<br>
<br>
These regression tests are supposed to test small code
model support, but have<br>
been XFAIL'd because we don't have an in-tree memory
manager that can guarantee<br>
a small-code-model compatible memory layout.
Unfortunately, they can<br>
occasionally pass if they get lucky with memory
allocation, causing unexpected<br>
passes on the bots. That's not very helpful.<br>
<br>
I'm going to remove these until we have the
infrastructure (small-code-model<br>
compatible memory manager) to run them properly.<br>
<br>
<br>
Removed:<br>
llvm/trunk/test/ExecutionEngine/MCJIT/hello-sm-pic.ll<br>
llvm/trunk/test/ExecutionEngine/OrcMCJIT/hello-sm-pic.ll<br>
<br>
Removed: llvm/trunk/test/ExecutionEngine/MCJIT/hello-sm-pic.ll<br>
URL: <a moz-do-not-send="true" href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_llvm_trunk_test_ExecutionEngine_MCJIT_hello-2Dsm-2Dpic.ll-3Frev-3D233721-26view-3Dauto&d=AwMDaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=0FMbYu2NNIaloVe3XJYPMw0Y8mwKSncoWYfqpmqnTlw&s=Hkm4lyYxqTY-3su-JJ3exmcmMqlBv6aD9bkTXnyy1ts&e=" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/ExecutionEngine/MCJIT/hello-sm-pic.ll?rev=233721&view=auto</a><br>
==============================================================================<br>
--- llvm/trunk/test/ExecutionEngine/MCJIT/hello-sm-pic.ll
(original)<br>
+++ llvm/trunk/test/ExecutionEngine/MCJIT/hello-sm-pic.ll
(removed)<br>
@@ -1,12 +0,0 @@<br>
-; RUN: %lli -relocation-model=pic -code-model=small
%s > /dev/null<br>
-; XFAIL: mips, i686, i386, darwin, aarch64, arm<br>
-<br>
-@.LC0 = internal global [12 x i8] c"Hello World\00"
; <[12 x i8]*> [#uses=1]<br>
-<br>
-declare i32 @puts(i8*)<br>
-<br>
-define i32 @main() {<br>
- %reg210 = call i32 @puts( i8* getelementptr
([12 x i8], [12 x i8]* @.LC0, i64 0, i64 0) )
; <i32> [#uses=0]<br>
- ret i32 0<br>
-}<br>
-<br>
<br>
Removed: llvm/trunk/test/ExecutionEngine/OrcMCJIT/hello-sm-pic.ll<br>
URL: <a moz-do-not-send="true" href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_llvm_trunk_test_ExecutionEngine_OrcMCJIT_hello-2Dsm-2Dpic.ll-3Frev-3D233721-26view-3Dauto&d=AwMDaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=0FMbYu2NNIaloVe3XJYPMw0Y8mwKSncoWYfqpmqnTlw&s=LR16Y4A4gBmr74ipYvJqLN76Pfs4IdvpugPfgx8Vy0A&e=" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/ExecutionEngine/OrcMCJIT/hello-sm-pic.ll?rev=233721&view=auto</a><br>
==============================================================================<br>
--- llvm/trunk/test/ExecutionEngine/OrcMCJIT/hello-sm-pic.ll
(original)<br>
+++ llvm/trunk/test/ExecutionEngine/OrcMCJIT/hello-sm-pic.ll
(removed)<br>
@@ -1,12 +0,0 @@<br>
-; RUN: %lli -jit-kind=orc-mcjit -relocation-model=pic
-code-model=small %s > /dev/null<br>
-; XFAIL: mips, i686, i386, darwin, aarch64, arm<br>
-<br>
-@.LC0 = internal global [12 x i8] c"Hello World\00"
; <[12 x i8]*> [#uses=1]<br>
-<br>
-declare i32 @puts(i8*)<br>
-<br>
-define i32 @main() {<br>
- %reg210 = call i32 @puts( i8* getelementptr
([12 x i8], [12 x i8]* @.LC0, i64 0, i64 0) )
; <i32> [#uses=0]<br>
- ret i32 0<br>
-}<br>
-<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a moz-do-not-send="true" href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a moz-do-not-send="true" href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote>
<br>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</blockquote>
<br>
</body>
</html>