[PATCH] D10679: Internalize: internalize comdat members as a group, and drop comdat on such members.

[Peter Collingbourne]

pcc added inline comments.

================
Comment at: lib/Transforms/IPO/Internalize.cpp:187
@@ +186,3 @@
+      checkComdatVisibility(GV, ExternalComdats);
+    for (GlobalAlias &GA : M.aliases())
+      checkComdatVisibility(GA, ExternalComdats);
----------------
rafael wrote:
> An alias is in the comdat of the aliasee, so I don't think you have to check them.
Suppose we have

```
$c = comdat selectany
@a = external global i32 0, comdat($c)
@b = alias i32* @a
```

and there exists an external reference to b. In that case we need to expose the c comdat.


http://reviews.llvm.org/D10679