[PATCH] D10679: Internalize: internalize comdat members as a group, and drop comdat on such members.

Rafael Ávila de Espíndola rafael.espindola at gmail.com
Wed Jul 15 22:28:01 PDT 2015


rafael accepted this revision.
rafael added a reviewer: rafael.
rafael added a comment.
This revision is now accepted and ready to land.

LGTM


================
Comment at: lib/Transforms/IPO/Internalize.cpp:187
@@ +186,3 @@
+      checkComdatVisibility(GV, ExternalComdats);
+    for (GlobalAlias &GA : M.aliases())
+      checkComdatVisibility(GA, ExternalComdats);
----------------
An alias is in the comdat of the aliasee, so I don't think you have to check them.


http://reviews.llvm.org/D10679







More information about the llvm-commits mailing list