[PATCH] [PM/AA] Completely remove the AliasAnalysis::copyValue interface.

Pete Cooper peter_cooper at apple.com
Mon Jul 13 10:33:59 PDT 2015


> On Jul 10, 2015, at 9:16 PM, Chandler Carruth <chandlerc at google.com> wrote:
> 
> On Thu, Jul 2, 2015 at 10:11 AM Pete Cooper <peter_cooper at apple.com <mailto:peter_cooper at apple.com>> wrote:
>> On Jul 1, 2015, at 8:37 PM, Chandler Carruth <chandlerc at gmail.com <mailto:chandlerc at gmail.com>> wrote:
>> 
>> It can return if and when we need it and know
>> how to build it on top of the new pass manager
> 
> Just to double check what you mean here.  Are you planning on adding AA updating API which only works with the new pass manager?
> 
> I'm not planning on adding one at all to start with. I just don't want to spend time refactoring things to make the current one work in both old and new.
> 
> However, I'm going to send mail with how I think an update API should probably look, and I'll try to look at what it would take to implement such a thing for both the old and new pass managers.
Thanks.  Thats fine.  My worry was that this would be implemented only in the new pass manager.  

I think to ease the transition to the new pass manager, we shouldn’t have this API there unless its also in the current pass manager.  Or we just wait until the new one is the only one.  I’m fine either way, but I just don’t want adoption of the new pass manager to be blocked on having to track down subtle behavior differences which could easily arise from this API.

Anyway, I think we’re in agreement here, but just wanted to give my opinion.
> 
> 
> Anyways, going to go ahead with this based on Hal's LGTM... we can re-add dead code any time. =]
Er, didn’t know thats how we did things but ok.  I thought that answering any open questions like mine would be done before committing, even if there’s a LGTM.
>  
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu <mailto:llvm-commits at cs.uiuc.edu>
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits <http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150713/c8a77b4b/attachment.html>


More information about the llvm-commits mailing list