<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Jul 10, 2015, at 9:16 PM, Chandler Carruth <<a href="mailto:chandlerc@google.com" class="">chandlerc@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><div class="gmail_quote"><div dir="ltr" class="">On Thu, Jul 2, 2015 at 10:11 AM Pete Cooper <<a href="mailto:peter_cooper@apple.com" class="">peter_cooper@apple.com</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word" class=""><div class=""><blockquote type="cite" class=""><div class="">On Jul 1, 2015, at 8:37 PM, Chandler Carruth <<a href="mailto:chandlerc@gmail.com" target="_blank" class="">chandlerc@gmail.com</a>> wrote:</div><br class=""><div class=""><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline!important" class="">It can return if and when we need it and know</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px" class=""><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline!important" class="">how to build it on top of the new pass manager</span></div></blockquote></div></div><div style="word-wrap:break-word" class=""><div class="">Just to double check what you mean here. Are you planning on adding AA updating API which only works with the new pass manager?</div></div></blockquote><div class=""><br class=""></div><div class="">I'm not planning on adding one at all to start with. I just don't want to spend time refactoring things to make the current one work in both old and new.</div><div class=""><br class=""></div><div class="">However, I'm going to send mail with how I think an update API should probably look, and I'll try to look at what it would take to implement such a thing for both the old and new pass managers.</div></div></div></div></blockquote>Thanks. Thats fine. My worry was that this would be implemented only in the new pass manager. </div><div><br class=""></div><div>I think to ease the transition to the new pass manager, we shouldn’t have this API there unless its also in the current pass manager. Or we just wait until the new one is the only one. I’m fine either way, but I just don’t want adoption of the new pass manager to be blocked on having to track down subtle behavior differences which could easily arise from this API.</div><div><br class=""></div><div>Anyway, I think we’re in agreement here, but just wanted to give my opinion.<br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class="gmail_quote"><div class=""><br class=""></div><div class=""><br class=""></div><div class="">Anyways, going to go ahead with this based on Hal's LGTM... we can re-add dead code any time. =]</div></div></div></div></blockquote>Er, didn’t know thats how we did things but ok. I thought that answering any open questions like mine would be done before committing, even if there’s a LGTM.<br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class="gmail_quote"><div class=""> <br class=""></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word" class=""><br class=""></div>_______________________________________________<br class="">
llvm-commits mailing list<br class="">
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank" class="">llvm-commits@cs.uiuc.edu</a><br class="">
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank" class="">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br class="">
</blockquote></div></div>
</div></blockquote></div><br class=""></body></html>